Skip to content

docs: external services#60

Merged
Klakurka merged 3 commits intomasterfrom
feat/document-external-calls
May 9, 2025
Merged

docs: external services#60
Klakurka merged 3 commits intomasterfrom
feat/document-external-calls

Conversation

@lissavxo
Copy link
Collaborator

@lissavxo lissavxo commented May 2, 2025

Related to [#48]
Added a description of each external services being called.

@Klakurka Klakurka requested a review from xecdev May 3, 2025 00:34
Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor text edits on product names.

README.txt Outdated

== External services ==

- Paybutton websocket
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with PayButton instead of Paybutton.

README.txt Outdated
== External services ==

- Paybutton websocket
This plugin connects to the Paybutton WebSocket, a service that monitors blockchain transactions.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated

- Paybutton websocket
This plugin connects to the Paybutton WebSocket, a service that monitors blockchain transactions.
It is used to detect payments made to the Paybutton/Widget address in real time.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated
This plugin connects to the Paybutton WebSocket, a service that monitors blockchain transactions.
It is used to detect payments made to the Paybutton/Widget address in real time.
The plugin uses the provided address to establish a connection and begins listening for events emitted when new transactions are detected.
This service is provided by Paybutton.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated
The plugin uses the provided address to establish a connection and begins listening for events emitted when new transactions are detected.
This service is provided by Paybutton.

- Paybutton API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated
- Paybutton API
This plugin communicates with the Paybutton API to fetch information about the address and its transactions.
It provides data such as the transaction price and the address balance, which are used by the widget and the button.
This service is also provided by Paybutton.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated
It provides data such as the transaction price and the address balance, which are used by the widget and the button.
This service is also provided by Paybutton.

- Sideshift.AI API
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go with SideShift instead of Sideshift.

README.txt Outdated
This service is also provided by Paybutton.

- Sideshift.AI API
The integration uses the Sideshift API to enable the button or widget to accept payments in a different currency than the one being received.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated

- Sideshift.AI API
The integration uses the Sideshift API to enable the button or widget to accept payments in a different currency than the one being received.
This service is provided by Sideshift.AI.[https://sideshift.ai/legal]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here.

README.txt Outdated
This plugin connects to the Paybutton WebSocket, a service that monitors blockchain transactions.
It is used to detect payments made to the Paybutton/Widget address in real time.
The plugin uses the provided address to establish a connection and begins listening for events emitted when new transactions are detected.
This service is provided by Paybutton.
Copy link
Collaborator

@xecdev xecdev May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add PayButton's "Privacy Policy" and "Terms of Use" links.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well we don't have these so if they require them, it will take time to add those.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lissavxo can you add links to the TERMS and PRIVACY files?

README.txt Outdated
- Paybutton API
This plugin communicates with the Paybutton API to fetch information about the address and its transactions.
It provides data such as the transaction price and the address balance, which are used by the widget and the button.
This service is also provided by Paybutton.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here: add PayButton's "Privacy Policy" and "Terms of Use" links.

Copy link
Member

@Klakurka Klakurka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We'll correct a few things in the next PR.

@Klakurka Klakurka merged commit a3dee03 into master May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants