Update all eCash related references to more generic names#38
Merged
Conversation
Klakurka
approved these changes
Mar 15, 2025
| $old_value = get_option( 'paybutton_paywall_ecash_address', '' ); | ||
| $new_value = get_option( 'pb_paywall_admin_wallet_address', '' ); | ||
|
|
||
| // If old_value is present and new_value is empty, copy old to new and remove old. |
Member
There was a problem hiding this comment.
Comments explaining the 'what' are usually pretty useless and this is a good example. Comments should cover the 'why' and then the code itself should be relatively easy to read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactors the codebase to replace all eCash-specific references (including variable names, CSS class names, and general mentions) with more generic terms. This refactoring not only improves code quality but also lays the groundwork for supporting additional cryptocurrencies like BCH, DOGE, and BTC.
Key Changes:
ecash_addressin the wp_paybutton_paywall_unlocked table is now renamed topb_paywall_user_wallet_address.Test plan:
1. Existing WordPress Site:
wp_paybutton_paywall_unlockedtable, select the data and see if the columnecash_addressname has changed topb_paywall_user_wallet_address2. New WordPress Site: