fix: ignore undefined fields signature#1048
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
Fixes an issue where undefined, null, or empty fields were being included in signature payload generation, causing unwanted '+' signs at the beginning of the signature payload string.
- Filter out undefined, null, and empty string values before joining signature payload components
- Extract the mapping result to a variable for cleaner filtering logic
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
| return valueString | ||
| }).join('+') | ||
| }).filter(value => value !== undefined && value !== null && value !== '') |
There was a problem hiding this comment.
[nitpick] The filter condition can be simplified using a more concise truthy check. Consider using .filter(Boolean) or .filter(value => value) instead of explicitly checking for undefined, null, and empty string, as these are all falsy values.
Suggested change
| }).filter(value => value !== undefined && value !== null && value !== '') | |
| }).filter(Boolean) |
chedieck
approved these changes
Aug 22, 2025
chedieck
approved these changes
Aug 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1047
Description
Ignore undefined fields when creating signature payload to remove the + sign in the beginning of the signature payload
Test plan
Create a POST trigger with txid, timestamp, and signature fields check if the signature payload fields does not have an extra + in the beginning