Replace --ipaddress and --domain with --target#6
Open
romainrichard wants to merge 2 commits intoPavornoc:masterfrom
Open
Replace --ipaddress and --domain with --target#6romainrichard wants to merge 2 commits intoPavornoc:masterfrom
--ipaddress and --domain with --target#6romainrichard wants to merge 2 commits intoPavornoc:masterfrom
Conversation
This simplifies the interface, no need for the user to switch arguments, the script will figure it out itself just like it does with the values in the file passed with the --file argument. Factorize the code a bit more: * Added get_args() to handle argument parsing * Added check_targets() to handle checking targets This helps keep the main() function short and clean. It also now allows users to easily call this script without using the CLI, by writing a new python script: ``` from investigate import SHODAN, WHOIS, check_targets check_targets(["abc.com", "1.2.3.4"], [SHODAN, WHOIS]) ``` Move the ip_check() and domain_check() functions to be next to check_targets(), I think it makes more sense than having those all the way at the bottom while the other functions related to those are at the top.
|
hello I am getting why ı did get this response code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This simplifies the interface, no need for the user to switch arguments,
the script will figure it out itself just like it does with the values
in the file passed with the
--fileargument.Factorize the code a bit more:
get_args()to handle argument parsingcheck_targets()to handle checking targetsThis helps keep the
main()function short and clean.It also now allows users to easily call this script without using the
CLI, by writing a new python script:
Move the
ip_check()anddomain_check()functions to be next tocheck_targets(), I think it makes more sense than having those all theway at the bottom while the other functions related to those are at the
top.