Shortcut in breakTime when referring to same day#94
Open
jamesmyatt wants to merge 5 commits intoPaulStoffregen:masterfrom
Open
Shortcut in breakTime when referring to same day#94jamesmyatt wants to merge 5 commits intoPaulStoffregen:masterfrom
jamesmyatt wants to merge 5 commits intoPaulStoffregen:masterfrom
Conversation
jamesmyatt
force-pushed
the
feature/cache
branch
from
79723f6 to
f72db9a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Converting days since 1970 to weekday, day, month, year is expensive, but can use internal cache of time elements to skip this calculation when the day hasn't changed.
This also fixes a bug in
void setTime(int hr,int min,int sec,int dy, int mnth, int yr)that the cacheTime and Wday element weren't updated.