This repository was archived by the owner on Jun 3, 2024. It is now read-only.
Impl ModelBakeEvent, ModelRegistryEvent and some ModelLoader methods #106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheGlitch76
reviewed
Jul 2, 2020
Member
TheGlitch76
left a comment
TheGlitch76
left a comment
There was a problem hiding this comment.
Conceptually this looks good, just some style changes.
patchwork-model-loader/src/main/java/net/minecraftforge/client/model/ModelLoader.java
Outdated
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/minecraftforge/client/model/ModelLoader.java
Outdated
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/impl/modelloader/AbstractModelLoader.java
Outdated
Show resolved
Hide resolved
patchwork-model-loader/src/main/resources/patchwork-model-loader.mixins.json
Outdated
Show resolved
Hide resolved
Co-authored-by: Glitch <[email protected]>
TheGlitch76
suggested changes
Jul 3, 2020
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Outdated
Show resolved
Hide resolved
TheGlitch76
suggested changes
Jul 5, 2020
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Show resolved
Hide resolved
...ork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinBakedModelManager.java
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/minecraftforge/client/model/ModelLoader.java
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Outdated
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Outdated
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/impl/modelloader/ModelEventDispatcher.java
Show resolved
Hide resolved
patchwork-model-loader/src/main/java/net/patchworkmc/mixin/modelloader/MixinModelLoader.java
Show resolved
Hide resolved
Co-authored-by: famous1622 <[email protected]>
TheGlitch76
approved these changes
Jul 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.