Merged
Conversation
davidschreiber
changed the title
radazzouz
approved these changes
Jul 23, 2021
Contributor
radazzouz
left a comment
radazzouz
left a comment
There was a problem hiding this comment.
Works great! I tested both the Catalog and NativeCatalog example projects on Android and iOS and they work great!
I also tested the integration into newly created projects using this branch on both Android and iOS. Everything works great!
I'm approving and merging!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
PSPDFKIT_VERSIONto Android 7Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json,samples/Catalog/yarn.lock,samples/NativeCatalog/package.json, andsamples/NativeCatalog/yarn.lock(see example commit: b32b4ed).