Remove the trial license key requirement#403
Merged
Conversation
steviki
approved these changes
May 26, 2021
Contributor
steviki
left a comment
steviki
left a comment
There was a problem hiding this comment.
iOS changes look good to me!
Co-authored-by: Stefan Kieleithner <stefan.kieleithner@gmail.com>
Co-authored-by: Stefan Kieleithner <stefan.kieleithner@gmail.com>
radazzouz
changed the title
amit-nayar
approved these changes
May 26, 2021
| ext { | ||
| buildToolsVersion = "28.0.3" | ||
| - minSdkVersion = 16 | ||
| + minSdkVersion = 19 |
Contributor
There was a problem hiding this comment.
Do we not need to set this anymore?
Contributor
Author
There was a problem hiding this comment.
No, the minSdkVersion for a newly created project is now 21.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
The new getting started instructions from the README are very similar to the ones from https://pspdfkit.com/getting-started/mobile/?frontend=react-native&react-native-platform=android&project=new-project
Release Notes
Acceptance Criteria
yarn add github:PSPDFKit/react-native#rad/remove-trial-license-key-requirementfor the fourth step.package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: ae02732).