Skip to content

Update Getting Started instructions on Android and iOS #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radazzouz merged 2 commits into from
Mar 3, 2021
Merged

Update Getting Started instructions on Android and iOS #390

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3328ed6
Update Getting Started instructions on Android and iOS
Mar 3, 2021
ee1c192
Bump version to 1.30.9
Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ To make sure this is fast, please use a work email and have someone from your co
#### Requirements

- The latest [Xcode](https://developer.apple.com/xcode/).
- PSPDFKit 10.2.0 for iOS or later
- PSPDFKit 10.2.1 for iOS or later
- react-native >= 0.63.4
- CocoaPods >= 1.10.1

Expand Down Expand Up @@ -76,10 +76,10 @@ target 'YourApp' do
#
# Note that if you have use_frameworks! enabled, Flipper will not work and
# you should disable these next few lines.
use_flipper!
post_install do |installer|
flipper_post_install(installer)
end
- use_flipper!
- post_install do |installer|
- flipper_post_install(installer)
- end
Comment on lines -79 to +82
Copy link
Contributor Author

@radazzouz radazzouz Mar 3, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We disable Flipper to workaround an known issue: facebook/react-native#30836 (comment)

end
```

Expand Down Expand Up @@ -368,6 +368,7 @@ For a runnable example, please take a look at the [AnnotationProcessing example
#### Requirements

- Android SDK
- Android NDK
- Android Build Tools 23.0.1 (React Native)
- Android Build Tools 28.0.3 (PSPDFKit module)
- Android Gradle plugin >= 3.4.1
Expand Down
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "react-native-pspdfkit",
"version": "1.30.8",
"version": "1.30.9",
"description": "A React Native module for the PSPDFKit library.",
"keywords": [
"react native",
Expand Down
2 changes: 1 addition & 1 deletion samples/Catalog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "Catalog",
"version": "1.30.8",
"version": "1.30.9",
"private": true,
"scripts": {
"start": "react-native start",
Expand Down
2 changes: 1 addition & 1 deletion samples/NativeCatalog/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "NativeCatalog",
"version": "1.30.8",
"version": "1.30.9",
"private": true,
"scripts": {
"android": "react-native run-android",
Expand Down