Conversation
…osave via the `disableAutomaticSaving` prop
autosaveEnabled configuration option when disabling autosave via the disableAutomaticSaving propdisableAutomaticSaving did not work when useParentNavigationBar was enabled.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Details
When disabling autosave via the
disableAutomaticSavingprop, we also need to disable theautosaveEnabledconfiguration option. This caused an issue where autosave still occurred even after settingdisableAutomaticSavingto true.See Z-22960
How to Reproduce on the main branch:
useParentNavigationBartotrue:ManualSave
class ManualSave extends Component { render() { return ( <View style={{ flex: 1 }}> <PSPDFKitView ref="pdfView" document={"PDFs/Annual Report.pdf"} disableAutomaticSaving={true} configuration={{ backgroundColor: processColor("lightgrey"), showThumbnailBar: "scrollable", + useParentNavigationBar: true, }} style={{ flex: 1, color: pspdfkitColor }} /> <View style={{ flexDirection: "row", height: 60, alignItems: "center", padding: 10, }} > <View> <Button onPress={() => { // Manual Save this.refs.pdfView .saveCurrentDocument() .then((result) => { if (result) { alert("Successfully saved current document."); } else { alert("Failed to save current document."); } }) .catch((error) => { alert(JSON.stringify(error)); }); }} title="Save" /> </View> </View> </View> ); } }Expected:
The newly added annotation should not have been saved.
Actual:
The newly added annotation is saved despite the fact that
disableAutomaticSavingwas set to true.Acceptance Criteria
package.json,package-lock.json,samples/Catalog/package.json, andsamples/NativeCatalog/package.json(see example commit: 1bf805f).