Skip to content

Fix stamps not being correctly detected #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
radazzouz merged 2 commits into from
Jan 11, 2021
Merged

Fix stamps not being correctly detected #384

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
011520a
Fix stamps not being correctly detected
Jan 5, 2021
8001ede
Fix stamps and polylines not being correctly detected on iOS
Jan 5, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions android/src/main/java/com/pspdfkit/react/helper/ConversionHelpers.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ public static EnumSet<AnnotationType> getAnnotationTypeFromString(@Nullable fina
if ("pspdfkit/text".equalsIgnoreCase(type)) {
return EnumSet.of(AnnotationType.FREETEXT);
}
if ("pspdfkit/stamp".equalsIgnoreCase(type)) {
return EnumSet.of(AnnotationType.STAMP);
}
return EnumSet.noneOf(AnnotationType.class);
}
}
4 changes: 4 additions & 0 deletions ios/RCTPSPDFKit/Converters/RCTConvert+PSPDFAnnotation.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,14 @@ + (PSPDFAnnotationType)annotationTypeFromInstantJSONType:(NSString *)type {
return PSPDFAnnotationTypeLine;
} else if ([type isEqualToString:@"pspdfkit/shape/polygon"]) {
return PSPDFAnnotationTypePolygon;
} else if ([type isEqualToString:@"pspdfkit/shape/polyline"]) {
return PSPDFAnnotationTypePolyLine;
} else if ([type isEqualToString:@"pspdfkit/shape/rectangle"]) {
return PSPDFAnnotationTypeSquare;
} else if ([type isEqualToString:@"pspdfkit/text"]) {
return PSPDFAnnotationTypeFreeText;
} else if ([type isEqualToString:@"pspdfkit/stamp"]) {
return PSPDFAnnotationTypeStamp;
} else {
return PSPDFAnnotationTypeUndefined;
}
Expand Down