Skip to content

Fixes issue where the last page view would be layed out incorrectly in single page mode and scroll per spread page trasition after device rotation#377

Merged
radazzouz merged 2 commits intomasterfrom
rad/fix-last-page-view-layout-after-rotation
Sep 14, 2020
Merged

Fixes issue where the last page view would be layed out incorrectly in single page mode and scroll per spread page trasition after device rotation#377
radazzouz merged 2 commits intomasterfrom
rad/fix-last-page-view-layout-after-rotation

Conversation

@radazzouz
Copy link
Contributor

@radazzouz radazzouz commented Sep 14, 2020

Fixes https://github.com/PSPDFKit/PSPDFKit/issues/25653


Details

How to Reproduce:

  • Modify ConfiguredPDFViewComponent like so:
class ConfiguredPDFViewComponent extends Component {
  render() {
    return (
      <View style={{ flex: 1 }}>
        <PSPDFKitView
          document={"PDFs/Annual Report.pdf"}
          configuration={{
            backgroundColor: processColor("lightgrey"),
            showThumbnailBar: "scrubberBar",
            showDocumentLabel: false,
            useParentNavigationBar: false,
            allowToolbarTitleChange: false,
+           pageMode: 'single',
+           pageTransition: 'scrollPerSpread'
          }}
          toolbarTitle={"Custom Title"}
          style={{ flex: 1, color: pspdfkitColor }}
        />
      </View>
    );
  }
}
  • Go to the last page
  • Rotate the device a few times

Expected:

The last page view should always be centered.

Actual:

The last page view will be layed out incorrectly.

Screen Shot 2020-09-14 at 10 55 22 AM

Acceptance Criteria

  • Fix the issue.
  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

…single page mode and scroll per spread page trasition after device rotation
Copy link
Contributor

@steviki steviki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@radazzouz radazzouz merged commit 25d5bc6 into master Sep 14, 2020
@radazzouz radazzouz deleted the rad/fix-last-page-view-layout-after-rotation branch September 14, 2020 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments