Skip to content

Fix issue where adding images in PdfViewComponent didn't work#375

Merged
irgendeinich merged 2 commits intomasterfrom
reinhard/fix-adding-images
Aug 13, 2020
Merged

Fix issue where adding images in PdfViewComponent didn't work#375
irgendeinich merged 2 commits intomasterfrom
reinhard/fix-adding-images

Conversation

@irgendeinich
Copy link
Contributor

@irgendeinich irgendeinich commented Aug 13, 2020

Details

This fixes an issue where you were unable to add images from the gallery or camera in the PdfViewComponent.

Acceptance Criteria

  • When approved, right before merging, rebase with master and increment the package version in package.json, package-lock.json, samples/Catalog/package.json, and samples/NativeCatalog/package.json (see example commit: 1bf805f).
  • Create a new release (and tag) with the new package version (see https://github.com/PSPDFKit/react-native/releases).

… was not delivered to the GalleryImagePickerFragment and CameraImagePickerFragment
Copy link
Contributor

@simoarpe simoarpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

Copy link
Contributor

@radazzouz radazzouz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not impact iOS.

@irgendeinich irgendeinich merged commit 603a07f into master Aug 13, 2020
@irgendeinich irgendeinich deleted the reinhard/fix-adding-images branch August 13, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants