Skip to content

Remove preprocess from KISS-ICP #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benemer merged 1 commit into from
Mar 5, 2024
Merged

Remove preprocess from KISS-ICP #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion config/example.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

data:
deskew: False
preprocess: True
max_range: 100.0
min_range: 3.0

Expand Down
1 change: 0 additions & 1 deletion src/mapmos/config/config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@

class DataConfig(BaseModel):
deskew: bool = False
preprocess: bool = True
max_range: float = 100.0
min_range: float = 3.0

Expand Down
1 change: 0 additions & 1 deletion src/mapmos/odometry.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@
def parse_config(config_data: DataConfig, config_odometry: OdometryConfig):
kiss_config = KISSConfig()
kiss_config.data.deskew = config_data.deskew
kiss_config.data.preprocess = config_data.preprocess
kiss_config.data.max_range = config_data.max_range
kiss_config.data.min_range = config_data.min_range
kiss_config.mapping.voxel_size = config_odometry.voxel_size
Expand Down