[FIX][T15384] NEWS Analysis creates trace error when viewing date field#75
Merged
james-opusvl merged 1 commit intoremove-custom-frequencyfrom Aug 19, 2019
Merged
[FIX][T15384] NEWS Analysis creates trace error when viewing date field#75james-opusvl merged 1 commit intoremove-custom-frequencyfrom
james-opusvl merged 1 commit intoremove-custom-frequencyfrom
Conversation
Because effective_date_terminated was added was declared as an odoo field and the SQL view had references to date_terminated changed to effective_date_terminated (but date_terminated was not removed), the pivot view was trying to load date_terminated when is wasn't available on the SQL View. This commit adds both fields and changes the field string names so that it is clearer to the user of what they are selecting.
PeterAlabaster
approved these changes
Aug 16, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because effective_date_terminated was added and declared as an odoo field and the SQL view had references to date_terminated changed to effective_date_terminated (but date_terminated was not removed), the pivot view was trying to load date_terminated when is wasn't available on the SQL View. This commit adds both fields and changes the field string names so that it is clearer to the user of what they are selecting.