Radio buttons should be required fields on escalation form#100
Merged
DaeronAlagos merged 1 commit intoremove-custom-frequencyfrom Feb 4, 2020
Merged
Radio buttons should be required fields on escalation form#100DaeronAlagos merged 1 commit intoremove-custom-frequencyfrom
DaeronAlagos merged 1 commit intoremove-custom-frequencyfrom
Conversation
Escalation tasks, either by consolidated after an obs or individual could be submitted without having selected an option. The change adds the 'required' property to the input. Any additional selection (depending on the radio option yes/do) is added and made required by js manipulation of the DOM.
PeterAlabaster
approved these changes
Feb 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Escalation tasks, either by consolidated after an obs or individual could be submitted without having selected an option. The change adds the 'required' property to the input. Any additional selection (depending on the radio option yes/no) is added and made required by js manipulation of the DOM.