Change: Validate action 2 loaded list does not overlap special types.#400
Merged
PeterN merged 1 commit intoOpenTTD:masterfrom Nov 30, 2025
Merged
Change: Validate action 2 loaded list does not overlap special types.#400PeterN merged 1 commit intoOpenTTD:masterfrom
PeterN merged 1 commit intoOpenTTD:masterfrom
Conversation
rubidium42
approved these changes
Nov 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When creating an
Action2Real, the length of theloaded_listis not validated. If this reaches more than 0x80, it will overlap the non-realAction2VarandAction2Randomvalues used fortype.This change checks for any length >= 0x80 and raises an error if the list is too long.