Add: Constants for (new) station and roadstop animation and random triggers.#375
Merged
frosch123 merged 1 commit intoOpenTTD:masterfrom May 13, 2025
Merged
Add: Constants for (new) station and roadstop animation and random triggers.#375frosch123 merged 1 commit intoOpenTTD:masterfrom
frosch123 merged 1 commit intoOpenTTD:masterfrom
Conversation
Member
frosch123
commented
Apr 26, 2025
- There are two new animation triggers for stations and roadstops since Add: [NewGRF] Station/roadstop animation-triggers 'tile loop' (bit 7) and 'path reservation' (bit 8). OpenTTD#14080.
- Stations used a different naming pattern for animation triggers than other features, so add new constants.
- Add missing roadstop random triggers.
glx22
reviewed
Apr 27, 2025
nml/global_constants.py
Outdated
Comment on lines
+807
to
+809
| "OBJ_ANIM_IS_BUILT" : 0, # deprecated | ||
| "OBJ_ANIM_PERIODIC" : 1, # deprecated | ||
| "OBJ_ANIM_SYNC" : 2, # deprecated |
Contributor
There was a problem hiding this comment.
There's an integrated deprecation mechanism:
Suggested change
| "OBJ_ANIM_IS_BUILT" : 0, # deprecated | |
| "OBJ_ANIM_PERIODIC" : 1, # deprecated | |
| "OBJ_ANIM_SYNC" : 2, # deprecated | |
| "OBJ_ANIM_IS_BUILT" : "ANIM_TRIGGER_OBJ_BUILT", | |
| "OBJ_ANIM_PERIODIC" : "ANIM_TRIGGER_OBJ_TILELOOP", | |
| "OBJ_ANIM_SYNC" : "ANIM_TRIGGER_OBJ_256_TICKS", |
Same applies to station anim.
PeterN
approved these changes
Apr 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.