Codefix: Remove unneeded "global"#369
Merged
FLHerne merged 1 commit intoOpenTTD:masterfrom Mar 31, 2025
Merged
Conversation
FLHerne
reviewed
Mar 31, 2025
Contributor
FLHerne
left a comment
FLHerne
left a comment
There was a problem hiding this comment.
Can you please update the comment for spriteset_collections?
It appears to have been overlooked in b86d93
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Flake8 7.2.0 introduced new checks and in result we get
After some reading, these two
globalare not needed because we modify the actual object and not the reference to the object.So make flake8 happy again and remove the useless
global.