OIP-draft add exists to UtilityTokenInterface#5
OIP-draft add exists to UtilityTokenInterface#5benjaminbollen wants to merge 1 commit intoOpenST:masterfrom
exists to UtilityTokenInterface#5Conversation
|
TODO; write specification for cogateway |
benjaminbollen
changed the title
exists to UtilityTokenInterface
benjaminbollen
changed the title
exists to UtilityTokenInterfaceexists to UtilityTokenInterface
|
implemented in mosaic-contracts 0.10.0 |
schemar
left a comment
schemar
left a comment
There was a problem hiding this comment.
LGTM 
We should prevent deadlocks as early as possible and this seems to be the place. It is the first time where the target chain knows about the mint intention and the intended recipient.
In my opinion the "Simple Summary" could be made even more "simple".
"Motivation" could be more verbose, maybe.
| @@ -0,0 +1,64 @@ | |||
| --- | |||
| oip: <to be assigned> | |||
| title: <Staking Beneficiary Exists> | |||
There was a problem hiding this comment.
remove brackets when adding actual values that replace the placeholders.
jasonklein
left a comment
jasonklein
left a comment
There was a problem hiding this comment.
It might be helpful to explicitly state that, in the base case, UT.exists returns true.
| <!--A short (~200 word) description of the technical issue being addressed.--> | ||
| By default all addresses exist in the Ethereum specification. For internal | ||
| token economies addresses that are not internal should return `false` | ||
| for `UT.exists`. By including this check on `cogateway.confirmStakingIntent`, |
There was a problem hiding this comment.
confirmStakingIntent has been renamed to confirmStakeIntent
3 participants
No description provided.