Fix linux build's file source#399
Merged
silseva merged 1 commit intoOpenRTX:fix-file-sourcefrom Feb 14, 2026
Merged
Conversation
turnrye
force-pushed
the
fix-linux-file-source
branch
2 times, most recently
from
f7c86bc to
9999b07
Compare
Collaborator
|
Looks good! I'd put the documentation in the website, though: having a |
Collaborator
Author
Will do |
turnrye
force-pushed
the
fix-linux-file-source
branch
from
9999b07 to
5424064
Compare
Previous to this, the file source that is used on linux was not working for me. This change addresses those issues found. It also adds an example test file, which is just a decimated 24kHz version of the existing unit test file. Co-authored-by: GitHub Copilot <175728472+Copilot@users.noreply.github.com> Signed-off-by: Ryan Turner <ryan@turnrye.com>
turnrye
force-pushed
the
fix-linux-file-source
branch
from
5424064 to
11d6bb4
Compare
Collaborator
Author
|
This is ready for review again! |
Collaborator
|
I'd omit the baseband binary file: even though it can be useful, is quite heavy and it won't be used many times |
Collaborator
|
I forgot to mention that we already have some files with raw M17 baseband, in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As I was tinkering around, I discovered for the first time that the linux platform has a file source input. I couldn't get it to work for me though, and with a bit of troubleshooting I (with LLM assistance) found these changes made it work.
Since contributors working on protocol code could benefit from this as well, I figured this warranted adding more explicit documentation.