Fix compiler warnings for cupsdCheckAdminTask#226
Closed
SiliconA-Z wants to merge 1 commit intoOpenPrinting:masterfrom
Closed
Fix compiler warnings for cupsdCheckAdminTask#226SiliconA-Z wants to merge 1 commit intoOpenPrinting:masterfrom
SiliconA-Z wants to merge 1 commit intoOpenPrinting:masterfrom
Conversation
Member
|
All of this code needs a proper review and won't be staying like this forever... |
michaelrsweet
added
bug
SiliconA-Z
force-pushed
the
clion
branch
2 times, most recently
from
320cb48 to
05cdcb9
Compare
SiliconA-Z
force-pushed
the
clion
branch
2 times, most recently
from
aa2bf5f to
02fd993
Compare
Contributor
Author
Alright. But it's still safe to do to avoid a compiler warning. |
SiliconA-Z
force-pushed
the
clion
branch
5 times, most recently
from
8eb0e68 to
cf529ce
Compare
SiliconA-Z
force-pushed
the
clion
branch
3 times, most recently
from
578988c to
9ab6f7c
Compare
Make the function static since it isn't used outside the file nor does it have a prototype, as well as silence the warning about an unused parameter.
Member
|
Closing as the reworking of this function removes the need. See PR #269... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the function static since it isn't used outside the file nor does it have a prototype, as well as silence the warning about an unused parameter.