Conversation
syntron
force-pushed
the
OMCPath
branch
4 times, most recently
from
7514c47 to
13fec2c
Compare
syntron
force-pushed
the
OMCPath
branch
2 times, most recently
from
c8bddac to
b59e473
Compare
syntron
force-pushed
the
OMCPath
branch
4 times, most recently
from
1b64550 to
c45b4f7
Compare
|
@Sonyoyo could you please test if this is working on WSL and provide some feedback? I'm just coding blind regarding this option ... Feel free to use the testcase in |
|
@ondras12345 could you please advice on the unittest? In |
* not working: 3.10 * working: 3.12
* this is scripting output and, thus, it cannot be parsed
see commit ID: aa74b36 - [OMCPath] add more functionality and docstrings
* differentiate between
* Python >= 3.12 uses OMCPath based on OMC for filesystem operation
* Python < 3.12 uses a pathlib.Path based implementation which is
limited to OMCProcessLocal
error: "unlink" of "OMCPathReal" does not return a value (it only ever returns None) [func-returns-value]
adeas31
left a comment
adeas31
left a comment
There was a problem hiding this comment.
LGTM.
Important: due to limitations in pathlib.Path, this is not working for Python < 3.12! - I'm testing compatibility but got no overall success (local Linux seems to work / Windows fails for 3.10)
Did you figure out what is the limitation? Is there a workaround?
see 1acd916: there is a compatibility layer such that for Python < 3.12 pathlib.Path is used such that it will work on the same level as it is now (i.e. no regression but also not the new possibilities) |
2 participants
new class OMCPath which implements path handling based on OMC commands
currently just a prove of concept with a test case using docker
see issue #315 and PR #309
Important: due to limitations in pathlib.Path, this is not working for Python < 3.12! - I'm testing compatibility but got no overall success (local Linux seems to work / Windows fails for 3.10)