Rename internal variables and methods to start with _#304
Rename internal variables and methods to start with _#304adeas31 merged 67 commits intoOpenModelica:masterfrom
_#304Conversation
8255e68 to
d798e71
Compare
|
Rebased and fixed all conflicts. If the answer to all 3 questions in the original comment is 'yes', then this PR is ready for review and merge. If not, I'll rename the functions to indicate that they are internal. |
|
@arun3688 can you please answer the above questions and review this PR. |
|
Based on PR #312 the method |
|
@ondras12345 just as a side note: if these variables are modified / renamed - would it be possible to change them to lowercase, with words separated by underscores? I have tried to not touch such cases as I'm not sure if there is any rule regarding this within OMPython. However, here we would change it to private and, thus, have all possibilities to change it without touching a public API |
d798e71 to
9f63e65
Compare
Done. |
adeas31
left a comment
There was a problem hiding this comment.
Look good.
From myside it is fine to leave the isParameterChangeable(), setTempDirectory()and setCommandLineOptions() as part of public API.
As suggested in #254
I wasn't sure about these, so I left them alone:
isParameterChangeable()be part of the public API?setTempDirectory()be part of the public API?setCommandLineOptions()be part of the public API? (I.e. should it be allowed to set extra options after the object is constructed? We already have acommandLineOptionsarg in the constructor.)To minimize future merge conflicts, and for me to be able to take advantage of
pre-commitwhile making these changes, this PR is based on #289.