Skip to content

Comments

Some more code cleanups#258

Merged
adeas31 merged 3 commits intoOpenModelica:masterfrom
syntron:code_cleanup
Apr 23, 2025
Merged

Some more code cleanups#258
adeas31 merged 3 commits intoOpenModelica:masterfrom
syntron:code_cleanup

Conversation

@syntron
Copy link
Contributor

@syntron syntron commented Apr 17, 2025

additional cleanups which should be added before #257

  • Remove unreachable code
  • cleanup old code for Python 2.x
  • fix OMCSessionBase - the variables self.readonly and self.omc_cache are needed here
  • [ModelicaSystem] fix True in docstring
  • [OMCSessionBase] fix usage of excaptions - replace ex.message() by ex.msg()

@syntron
Copy link
Contributor Author

syntron commented Apr 17, 2025

see also discussion in #250 - small changes to make OMCSessionBase and OMCSessionZMQ more independent of each other

@adeas31 adeas31 merged commit 8230f67 into OpenModelica:master Apr 23, 2025
5 checks passed
@syntron syntron deleted the code_cleanup branch April 24, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants