Fix linearize() simflags must start with space#243
Merged
lochel merged 2 commits intoOpenModelica:masterfrom Apr 7, 2025
Merged
Fix linearize() simflags must start with space#243lochel merged 2 commits intoOpenModelica:masterfrom
lochel merged 2 commits intoOpenModelica:masterfrom
Conversation
Collaborator
|
@ondras12345 can you please sign the license/cla |
Contributor
Author
|
I have already done that when I was submitting #242. I see that the licese/cla check has passed, too. Do I need to do it for each PR separately? If so, how? Last time, the CLAassistant bot sent me a link. |
Member
|
No, the cla is fine. The other jobs need to be started manually for whatever reason. I just did so. |
lochel
approved these changes
Apr 6, 2025
Member
lochel
left a comment
lochel
left a comment
There was a problem hiding this comment.
A bit hacky, but seems to be alright.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, the flags supplied by the user in
simflagswould get appended to automatically generated flags without a space in a call like this:A workaround is to start simflags with a space:
This PR removes the need for the workaround.