DLRM OneEmbedding Graph Train and Eval#323
Merged
Conversation
* Arguments description * rectify README.md
MARD1NO
reviewed
Mar 25, 2022
| tail = [rglist[i][pos:] for i in range(self.C_end)] | ||
|
|
||
|
|
||
| class Dense(nn.Module): |
Contributor
There was a problem hiding this comment.
我有个想法（但我不确定这么做可不可以），就是不需要 Dense 了，默认都用 FusedMLP，如果环境不够 FusedMLP 内部其实也做了相应处理，用多个矩阵乘拼接。
Contributor
Author
There was a problem hiding this comment.
We can remove dense soon when we feel fully confident with more tests.
MARD1NO
reviewed
Mar 25, 2022
| ) | ||
|
|
||
| def forward(self, dense_fields, sparse_fields) -> flow.Tensor: | ||
| dense_fields = flow.log(dense_fields + 1.0) |
Contributor
Author
There was a problem hiding this comment.
Yes, we add a literal 1 for criteo1t and 3 for criteo kaggle dataset in data preprocess.
MARD1NO
reviewed
Mar 25, 2022
| @@ -0,0 +1,3 @@ | |||
| petastorm | |||
Contributor
Author
There was a problem hiding this comment.
worked on latest version
guo-ran
approved these changes
Mar 30, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OneFlow DLRM model with OneEmbedding train and evaluation in graph mode.