fix(security): redact secrets from config startup log (CWE-532)#391
Open
aayushbaluni wants to merge 1 commit intoOWASP:masterfrom
Open
fix(security): redact secrets from config startup log (CWE-532)#391aayushbaluni wants to merge 1 commit intoOWASP:masterfrom
aayushbaluni wants to merge 1 commit intoOWASP:masterfrom
Conversation
config/config.js logs the full config object including cookieSecret, cryptoKey, and the MongoDB connection URI on every startup via console.log(util.inspect(config)). In production, stdout feeds into centralized logging (CloudWatch, ELK, etc.), exposing secrets to anyone with log access. Gate config logging behind NODE_ENV=development + DEBUG_CONFIG env var, and redact sensitive values when logging is enabled. Fixes OWASP#390 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
config/config.jslogs the full configuration object to stdout on every startup, exposingcookieSecret,cryptoKey, and the MongoDB connection URI (which may contain credentials) to anyone with access to application logs.This is CWE-532 (Insertion of Sensitive Information into Log File).
Root Cause
Lines 12-13 of
config/config.jsunconditionally callconsole.log(util.inspect(config)), dumping the entire config including secrets.Fix
NODE_ENV === 'development'ANDDEBUG_CONFIGenvironment variablecookieSecret,cryptoKey, and credentials in thedbconnection stringFixes #390
Made with Cursor