1. Fixed plotting bugs and optimizer errors for systems with 4 shape variables#72
Merged
1. Fixed plotting bugs and optimizer errors for systems with 4 shape variables#72
Conversation
Contributor
sureshr14
commented
Oct 16, 2018
- Fixed plotting bugs and optimizer errors for systems with 4 shape variables
Updated mfield plotting
… fix Beta_draw as well
Contributor
|
Thanks. I've merged a few changes into that branch.
Two things that I noticed:
1. the Beta_draw functions aren't updated -- I started to update Beta_draw, but only got as far as adding the conditional check to run surf only if there was a 2d shapespace. (Along with making sure stretch was only applied for 2d systems, which I also put in CCF_draw). Could you make the rest of the changes needed for the beta draw functions, and test all plot functions for the higher-dimensional system? (I think illustrate shapespace needs help for 4-d systems)
2. I thought you said you had gaits being padded out or truncated to the appropriate number of shape variables -- did I misunderstand, or did that not make it into the upload?
===========
Ross L. Hatton
Associate Professor, School of MIME
Collaborative Robotics and Intelligent Systems Institute
Oregon State University
coris.oregonstate.edu
research.engr.oregonstate.edu/lram/
rosslhatton.com
ross.hatton@oregonstate.edu
… On Oct 16, 2018, at 1:42 PM, sureshr14 ***@***.***> wrote:
@sureshr14 <https://github.com/sureshr14> requested your review on: #72 <#72> 1. Fixed plotting bugs and optimizer errors for systems with 4 shape variables.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub <#72 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/APMajIJGGxl2oC1setP1QgV0LJXXZRcNks5ulkSugaJpZM4Xh4i8>.
|
2. Illustrate shape space works for 4 shape variable systems. 3. Beta draw and dbeta draw throw up not implemented message for higher dimensional system
…tems with >2 shape variables.
…ch with the dimensions of the chosen system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.