Skip to content

Parser: disentangle from JsonObject#4930

Draft
akva2 wants to merge 5 commits intoOPM:masterfrom
akva2:parser_no_json
Draft

Parser: disentangle from JsonObject#4930
akva2 wants to merge 5 commits intoOPM:masterfrom
akva2:parser_no_json

Conversation

@akva2
Copy link
Copy Markdown
Member

@akva2 akva2 commented Jan 26, 2026

This is a first step in making cjson a private dependency of opm-common, that is, to remove the dependency on cjson from the exported opm-common library. Eventually only the python bindings (to not break the api) and the keyword generator need cjson.

Less dependencies are good, and we avoid publishing vendored code when cjson is not on the system.

akva2 added 5 commits January 26, 2026 13:11
granted, one more step, but will help in disentangling
json from parser
only used in tests
only used in tests. remove some of the tests,
adjust others
@akva2 akva2 added the manual:irrelevant This PR is a minor fix and should not appear in the manual label Jan 26, 2026
@akva2
Copy link
Copy Markdown
Member Author

akva2 commented Jan 26, 2026

jenkins build this please

@akva2
Copy link
Copy Markdown
Member Author

akva2 commented Jan 26, 2026

if you prefer to see the whole thing, i will publish the rest as follow-up PR's.

@bska
Copy link
Copy Markdown
Member

bska commented Jan 26, 2026

to remove the dependency on cjson from the exported opm-common library

🎉

So the goal is, to some extent, to remove every reference to opm/json from the "public" parts of CMakeLists_files.cmake?

if you prefer to see the whole thing, i will publish the rest as follow-up PR's.

Yes please. That'd be great.

@bska
Copy link
Copy Markdown
Member

bska commented Jan 26, 2026

to remove the dependency on cjson from the exported opm-common library

Will this impact users' ability to define custom keywords through JSON? If so, we should at least think about the implications. This doesn't matter at all for the primary use case of deploying the parser as part of the simulator, but could be important for those who wish to use the parser in a more stand-alone context.

@akva2
Copy link
Copy Markdown
Member Author

akva2 commented Jan 26, 2026

i'm not going to break it, but you will need to link an additional opmjson library which contains the json to keyword stuff.

@bska
Copy link
Copy Markdown
Member

bska commented Jan 26, 2026

i'm not going to break it, but you will need to link an additional opmjson library which contains the json to keyword stuff.

That's a perfectly fine solution. Thanks!

@akva2 akva2 marked this pull request as draft January 26, 2026 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manual:irrelevant This PR is a minor fix and should not appear in the manual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants