web_responsive overhaul feeler

[ljmnoonan]

While working on trying to make my web_dark_mode work with web_responsive I have realized that it may be time for a bit of an overhaul.

However, before spending any time doing so I'd like to get the consensus of the users and maintainers of this module to see what I should and shouldn't do. Here are the main points:

Lack of Direction

Two themes for the app screen as well as 3 different search modes. I have read all the discussion on #2684 where this was introduced and feel like there should have been an agreement reached before going forward rather than just keeping all options. The two themes, especially, make implementing dark mode confusing and inconvenient.

As far as search modes go, my personal preference would be odoo command palette, but keep the search bar. I could possibly modify the css to line it up with the search bar in order to seem more coherent. In any case, I would not get rid of the search bar as it is the only thing allowing searches from mobile.

Getting rid of these options would also eliminate the need for the little drop icon in the navbar. If we cannot agree on a single mode + theme, I would like to also suggest moving this to the user preferences section as I don't see any real reason for it to be in the navbar.

Outdated Code

In 18.0 list view headers are sticky by default and in 19.0 form status bars are sticky too. Maybe other features too?

File Structure

Not really a big thing, but the file structure does not follow web. primary_varables.scss for instance are tucked away in a legacy folder. Also, everything to do with the home menu would be under webclient and probably not split between apps_menu and apps_menu_item. If there are no objections, I would like to reorganize this.

Redirect to Home

I like this feature, but it seems a bit out of place. Could it be incorporated into web_quick_start_screen? I would also like to add a little home button to the navbar and could have sworn that I have actually seen that done already somewhere. Anyway, not really the subject of this issue.

Lastly, the big question: should I start these modifications on 19.0 of 18.0 and would you prefer it be broken up into multiple PRs, or just one?

Thank you all!

[pedrobaeza]

As the "native" search can be triggered with Ctrl+K, and then typing /, I would reduce the menu search to the fuzz one.

I think the changes can be done in 19.0, that is still penetrating in the instances.

[ljmnoonan]

@pedrobaeza does the fuzz search offer any advantages over the native search? My understanding is that it allows for misspellings by using a less exact match. I do not have enough experience with it to know whether this makes a practical difference though.
On the other hand, making the search trigger the equivalent of Ctrl+K+/ would allow users not in the habit of using keyboard shortcuts to use the search bar to start not only a menu search, but also user and channel searches.

[pedrobaeza]

@ljmnoonan yes, it makes a total difference, and that's why I personally insist in keeping it. With the fuzz one, you can search "invcustinv" for "Invoicing / Customers / Invoices", while that can't be possible in the other search, having to type full path, which is far from convenient, going at the end for the scroll option to find the menu.

[ljmnoonan]

@pedrobaeza
This seems to already be implemented in the regular command palette

[pedrobaeza]

I think I have put a bad example. Use invcuscus for finding "Invoicing / Customers / Customers": no result.

[ljmnoonan]

@pedrobaeza ah, very interesting! Strangely enough, though, "Fuse" search also returns nothing, only "canonical" successfully searches that. So I guess canonical is the one to keep and relegate "command palette" to be activated only via keyboard shortcut.
Maybe someone with a better understanding of javascript can someday work this into odoo's default search.
Thank you for your time!