[18.0][MIG] stock_account_valuation_discrepancy_adjust #400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronHForgeFlow
approved these changes
Mar 13, 2025
Contributor
AaronHForgeFlow
left a comment
AaronHForgeFlow
left a comment
There was a problem hiding this comment.
Functional review. It works as expected. Just some minor comments.
| <field name="type">ir.actions.act_window</field> | ||
| <field name="res_model">product.discrepancy</field> | ||
| <field name="view_mode">tree</field> | ||
| <field name="domain">[('id', '=', -1)]</field> |
Contributor
There was a problem hiding this comment.
I think this can be removed. Ir was probably added by mistake in the previous version.
| ] | ||
| if not valuation_account: | ||
| raise UserError( | ||
| _("Product %s doesn't have stock valuation account assigned") |
Contributor
There was a problem hiding this comment.
Suggested change
| _("Product %s doesn't have stock valuation account assigned") | |
| self.env._("Product %s doesn't have stock valuation account assigned") |
| <field name="account_qty_at_date" /> | ||
| <field name="valuation_discrepancy" /> | ||
| <field name="qty_discrepancy" /> | ||
| <field name="to_date_valuation" invisible="1" /> |
Contributor
There was a problem hiding this comment.
I think this can be removed. It is not used.
| <form string="wizard_stock_discrepancy_adjustment_form"> | ||
| <sheet> | ||
| <group> | ||
| <field name="company_id" invisible="1" /> |
Contributor
There was a problem hiding this comment.
I think can be removed as well.
IsabelAForgeFlow
force-pushed
the
18.0-mig-stock_account_valuation_discrepancy_adjust
branch
from
e59f5d4 to
399d539
Compare
AaronHForgeFlow
approved these changes
Mar 14, 2025
Contributor
|
@IsabelAForgeFlow the dependency is merged 🎉 can you please rebase? |
…eate single journal entry
…ds from the wizard as long they are slow computed an unnecessary to take a decision
Currently translated at 100.0% (31 of 31 strings) Translation: stock-logistics-reporting-16.0/stock-logistics-reporting-16.0-stock_account_valuation_discrepancy_adjust Translate-URL: https://translation.odoo-community.org/projects/stock-logistics-reporting-16-0/stock-logistics-reporting-16-0-stock_account_valuation_discrepancy_adjust/it/
- Factor out move data preparation into separate methods - Split debit/credit line preparation into dedicated methods - Fix mismatch between company_id on default journal and company_id on record - Allow differentiating user set defaults by company - Fix strange decimal precision choices
IsabelAForgeFlow
force-pushed
the
18.0-mig-stock_account_valuation_discrepancy_adjust
branch
from
399d539 to
e8dff77
Compare
[MIG] stock_account_valuation_discrepancy_adjust: Migration to 18.0 [MIG] stock_account_valuation_discrepancy_adjust: Migration to 18.0
IsabelAForgeFlow
force-pushed
the
18.0-mig-stock_account_valuation_discrepancy_adjust
branch
from
e8dff77 to
b62157b
Compare
Author
Done! |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
BhaveshHeliconia
approved these changes
Aug 8, 2025
Contributor
BhaveshHeliconia
left a comment
BhaveshHeliconia
left a comment
There was a problem hiding this comment.
Functional review LGTM
Contributor
|
Ready to merge! 🚀 |
github-actions
bot
removed
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migration to 18.0