[18.0][MIG] report_qweb_element_page_visibility: Migration to 18.0 #956
Conversation
…age_visibility module These classes cause the element to be visible when the document is only a single page long (for single-page) or when it's multiple pages long (for multi-page). This is especially useful for page counters, which can be hidden when there's only a single page.
|
@OCA/reporting-engine-maintainers hello, can somebody do a review for me? |
…sibility the visibility attribute with the hidden option hides the element but don't free the space. A common use case is to have a specific header for the first page and another for the other pages. With visibility: hidden the second header cannot take the first one place and will keep a huge margin. One solution is to use the display:none instead.
Hello, thanks for your reply. |
StefanRijnhart
left a comment
StefanRijnhart
left a comment
There was a problem hiding this comment.
Perfect, thank you for picking the fix from #882!
Functional test and code review.
|
This PR has the |
|
/ocabot migration report_qweb_element_page_visibility |
|
What a great day to merge this nice PR. Let's do it! |
|
Congratulations, your PR was merged at ea7182d. Thanks a lot for contributing to OCA. ❤️ |
16 participants
No description provided.