Skip to content

Conversation

@MiquelRForgeFlow
Copy link
Contributor

When job fails, it shows in chatter:

Selection_2215

Later, the job does a retry. If the retry succeeds, the error is deleted. If not succeeds but the error is different, the error changes. In both cases, you cannot know what was the first error. Let's put in the chatter to have better history.

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-imp-queue_job-add-error-chatter branch from b0e1a0f to 9715565 Compare November 16, 2023 17:00
@PCatinean
Copy link
Contributor

I second this, db size should not be an issue with the autovacuum and exception info is indeed quite important

@MiquelRForgeFlow MiquelRForgeFlow force-pushed the 12.0-imp-queue_job-add-error-chatter branch from 9715565 to 7b7f2f5 Compare November 27, 2023 12:25
@MiquelRForgeFlow
Copy link
Contributor Author

MiquelRForgeFlow commented Nov 27, 2023

@simahawk @guewen please! Once merged, I will do forward ports...

Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Technically LGTM

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Next time pls, move the pre-commit update to another PR 🙏

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@etobella
Copy link
Member

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 12.0-ocabot-merge-pr-577-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit aa1e018 into OCA:12.0 Nov 27, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3ec3e8f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants