Minor webhooks/callbacks and schema examples improvements (3.1.1)#3862
Merged
ralfhandl merged 3 commits intoOAI:v3.1.1-devfrom Jun 10, 2024
Merged
Minor webhooks/callbacks and schema examples improvements (3.1.1)#3862ralfhandl merged 3 commits intoOAI:v3.1.1-devfrom
examples improvements (3.1.1)#3862ralfhandl merged 3 commits intoOAI:v3.1.1-devfrom
Conversation
Not only do we not capitalize the "h" elsewhere, this example, which pre-dated 3.1 webhooks, used the term in a confusinglty not-quite-the-same way.
3.1 deprecates the OAS extension `example` schema keyword in favor of the draft 2020-12 `examples` standard schema keyword.
ralfhandl
previously approved these changes
May 28, 2024
Contributor
ralfhandl
left a comment
There was a problem hiding this comment.
+1, formulation suggestion
ralfhandl
approved these changes
May 29, 2024
miqui
approved these changes
Jun 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes:
These are the minor editorial issues that do not apply to 3.0.4 and therefore do not fit in PR #3861 (which will be forward-ported as usual, but separately to ensure no one misses the 3.1.1-specific improvements).
Hopefully I did the right thing with webhooks vs callbacks here.