Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ package-lock.json
.pluginsrc
.idea/
lcov*
coverage/
coverage/
.history/*.*
7 changes: 5 additions & 2 deletions Plugin-Listing.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,10 +2,11 @@

| Command Name | Description | Plugin |
| --- | --- | --- |
| `Create Note From Calendar Event` | creates a note from a calendar event | 🧩 Event Automations |
| `Create Note From Calendar Event w/QuickTemplate` | creates a note from a calendar event | 🧩 Event Automations |
| `Create Note From Calendar Event` | creates a note from a calendar event | 🗓 Event Automations |
| `Create Note From Calendar Event w/QuickTemplate` | creates a note from a calendar event | 🗓 Event Automations |
| `add project` | add a new note representing a project, asking for its metadata | 🔬Reviews |
| `apply template` | Choose a Template to apply (append) to the current Note | 🔩 Templates |
| `atb - Create AutoTimeBlocks for >today's Tasks` | Read >today todos and insert them into today's calendar note as timeblocks | 🗓 Event Automations |
| `complete project` | add @completed(today) date to the open project | 🔬Reviews |
| `convertSelectionToHtml` | Convert current selection to HTML | 🧩 Codedungeon Toolbox |
| `convertToHtml` | Convert current note to HTML | 🧩 Codedungeon Toolbox |
Expand All @@ -15,6 +16,8 @@
| `dayReview` | Ask journal questions for an end-of-day review (requires configuring) | ☀️ Daily Journal |
| `dayStart` | Apply Daily Note Template (requires configuring) | ☀️ Daily Journal |
| `dp` | (Date Picker) Choose format and insert date/time time at cursor | 📅 Date Automations |
| `expensesAggregate` | Aggregates the tracked expenses of the chosen year to a new expenses aggregated note | 💶️ Expenses |
| `expensesTracking` | Provides multiple possibilities to track your expenses | 💶️ Expenses |
| `finish project review` | updates the current open project's @reviewed() date | 🔬Reviews |
| `formatted` | Insert custom formatted (format) date/time | 📅 Date Automations |
| `fp` | file (move) paragraphs to different notes | 📦 Filer |
Expand Down
6 changes: 5 additions & 1 deletion jgclark.Review/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,14 @@
# What's changed in 🔬 Reviews plugin?
See [website README for more details](https://github.com/NotePlan/plugins/tree/main/jgclark.Review), and how to configure.

## [0.4.4] - 2021-12-07
### Fixed
- in some cases /projectList output was failing to be written, which should fix issue #137 (thanks to @brettnotbritt)

## [0.4.1..0.4.3] - 2021-10-24
### Fixed
- updated some warning messages
- found that NP strips out hash symbols from note titles; this led to duplicate Review notes
- found that NP strips out hash symbols from note titles; this led to duplicate Review notes (later reported as #138 by @codedungeon)
- typo in default configuration that gets copied to _configuration

## [0.4.0] - 2021-09-10
Expand Down
2 changes: 1 addition & 1 deletion jgclark.Review/plugin.json
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
"plugin.icon": "",
"plugin.author": "Jonathan Clark",
"plugin.url": "https://github.com/NotePlan/plugins/tree/main/jgclark.Review/",
"plugin.version": "0.4.3",
"plugin.version": "0.4.4",
"plugin.dependencies": [],
"plugin.script": "script.js",
"plugin.isRemote": "false",
Expand Down
13 changes: 7 additions & 6 deletions jgclark.Review/src/reviews.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
//-----------------------------------------------------------------------------
// Commands for Reviewing project-style notes, GTD-style.
// by @jgclark
// v0.4.3, 24.10.2021
// v0.4.4, 7.12.2021
//-----------------------------------------------------------------------------

// Settings
Expand Down Expand Up @@ -71,7 +71,7 @@ export async function getConfig(): Promise<void> {
// $FlowFixMe -- don't know how to make this array not just object
pref_noteTypeTags = reviewConfig.noteTypeTags
}
// console.log(pref_noteTypeTags.toString())
console.log(pref_noteTypeTags.toString())
if (reviewConfig.folderToStore != null &&
typeof reviewConfig.folderToStore === 'string') {
pref_folderToStore = reviewConfig.folderToStore
Expand Down Expand Up @@ -102,10 +102,10 @@ export async function getConfig(): Promise<void> {
//-------------------------------------------------------------------------------
// Create human-readable lists of project notes for each tag of interest
export async function projectLists(): Promise<void> {
getConfig()
console.log(`\nprojectLists():`)
await getConfig()
console.log(`\nprojectLists() for ${pref_noteTypeTags.toString()} tags:`)

if (pref_noteTypeTags != null && pref_noteTypeTags.length > 0) {
if (pref_noteTypeTags.length > 0) {
// We have defined tag(s) to filter and group by
// $FlowFixMe[incompatible-type]
for (const tag of pref_noteTypeTags) {
Expand Down Expand Up @@ -161,7 +161,7 @@ export async function projectLists(): Promise<void> {
// ordered by oldest next review date
// V2, using reviewList pref
export async function startReviews() {
getConfig()
await getConfig()
// Get or make _reviews note
// const reviewsNote: ?TNote = await getOrMakeNote(reviewListNoteTitle, pref_folderToStore)
// if (reviewsNote == null) {
Expand Down Expand Up @@ -475,6 +475,7 @@ export async function completeReview(): Promise<?TNote> {
return Editor.note
}

//-------------------------------------------------------------------------------
// To help transition from the previous method which used a machine-readable
// file '_reviews' for persistent storage, this will remove it if found.
// TODO: remove this after some months, as no longer needed
Expand Down