Skip to content
This repository was archived by the owner on Jan 6, 2026. It is now read-only.

chore: electron v30, forge, vite, biomejs, arm builds#536

Merged
jgresham merged 60 commits intomainfrom
chore/electron-forge-and-29
Apr 22, 2024
Merged

chore: electron v30, forge, vite, biomejs, arm builds#536
jgresham merged 60 commits intomainfrom
chore/electron-forge-and-29

Conversation

@jgresham
Copy link
Copy Markdown
Member

@jgresham jgresham commented Apr 4, 2024

#457
#456
And gets us off of a slowly fading set of build tools and onto the new and official electron dev, build, and publishing tools

with Vite replacing Webpack, we should see much faster dev environments too

  • build and tests
  • forge indescriptive make fail blocking Error during packaging on macOS electron/forge#3549
  • package and publish
  • github actions
  • auto-updater
  • deep clean
  • storybook vite
  • e2e tests
  • switched to ESM modules as default (electron 28 started official support)

the only now outdated tool is typescript 4.5 instead of 5.x but many projects and starter templates are on 4.5, so not upgrading at this time. Not sure why projects are not using 5.x yet

  • auto-update plan from NN v5?

@netlify
Copy link
Copy Markdown

netlify bot commented Apr 4, 2024

Deploy Preview for nndesign ready!

Name Link
🔨 Latest commit 278e53b
🔍 Latest deploy log https://app.netlify.com/sites/nndesign/deploys/6626b7cc21b2b50008da6775
😎 Deploy Preview https://deploy-preview-536--nndesign.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

jgresham added 13 commits April 15, 2024 15:00
* vite.config.ts works with storybook but should integrate with existing vite renderer config

* custom storybook vite path

* convert storybook nn theme to ts. remove unused deps
* fix e2e test. convert tsconfig module to nodenext for esm
* fix prod publish gha
* use autoUpdater from electron with github feedUrl for dialog control
* deb and rpm updater split with package manager selection
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant