fix(imagepicker): consolidate API / Fix typings #530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NathanWalker
approved these changes
Sep 16, 2023
Contributor
NathanWalker
left a comment
NathanWalker
left a comment
There was a problem hiding this comment.
Really nice thank you @jcassidyav
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IOS and Android APIs have diverged with each other, the
.d.tsand the docs, this is an attempt to bring them all back into sync.Changes:
authorize() now returns a
Promise<AuthorizationResult>for both android and IOS, where theauthorizedproperty indicates success, and thedetailsproperty holds the returned value from the call to@nativescript-community/perms, previously IOS threw an error on , and android returned the raw response from@nativescript-community/permswhich came in two different forms depending on android version.In the returned result from
present()eachresult[i].thumbnailis now anImageSource, this was previously aBitMapfor android /ImageSourcefor IOS.result[i].durationis now typed correctly as anumber, previously typed as a string, but was always set with a number.Uses
@nativescript-community/permsin IOS.