[Minor] fix: do not requantize the scales in FP8 scale sweep calibration#825
[Minor] fix: do not requantize the scales in FP8 scale sweep calibration#825
Conversation
|
Important Review skippedAuto incremental reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the
📝 WalkthroughWalkthroughThese changes implement an optimized FP8 quantization path for NVFP4 static per-block quantization. When Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #825 +/- ##
=======================================
Coverage 73.44% 73.44%
=======================================
Files 194 194
Lines 20034 20034
=======================================
Hits 14714 14714
Misses 5320 5320 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@Fridah-nv can you please add [Minor] tag in the PR title? |
bdad690 to
1caa24f
Compare
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
Signed-off-by: Fridah-nv <201670829+Fridah-nv@users.noreply.github.com>
1caa24f to
aee1bd7
Compare
|
Fix applied in #849 |
Pull request was closed
What does this PR do?
Type of change: ?
Overview: ?
Usage
# Add a code snippet demonstrating how to use thisTesting
Before your PR is "Ready for review"
Additional Information
Summary by CodeRabbit
Release Notes
New Features
Improvements
✏️ Tip: You can customize this high-level summary in your review settings.