Add sewing kit and utilities used for pruning scoring - pruning scoring is self-contained now#584
Conversation
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
…ons_4 Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
…core_pruning_activations_5 Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
…core_pruning_activations_6sewing_kit
…korzekwa/score_pruning_activations_7
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## feature/compress #584 +/- ##
=================================================
Coverage 74.37% 74.37%
=================================================
Files 182 182
Lines 18219 18219
=================================================
Hits 13550 13550
Misses 4669 4669 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
| @@ -0,0 +1,15 @@ | |||
| # SPDX-FileCopyrightText: Copyright (c) 2024 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | |||
There was a problem hiding this comment.
This folder is empty other than this?
There was a problem hiding this comment.
Deleted this empty module. Note that later some content can be added here. Currently, we only add required modules from sewing_kit to support llama 3.1 8B ffn/att pruning scenario.
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
kevalmorabia97
left a comment
There was a problem hiding this comment.
Minor comments. Feel free to merge after addressing these
| if sys.version_info[1] < 9: # if less than pytorch 3.9 | ||
| from typing import Sequence, Callable | ||
| else: |
There was a problem hiding this comment.
modelopt only supports python 3.10+ so no need for if-else or from __future__ import annotations in any file
There was a problem hiding this comment.
removing from __future__ import annotations will fail on self-referencing, e.g.,
modelopt/torch/_compress/sewing_kit/passage/core.py:57: in InputArgs
def __add__(self, other: Any) -> InputArgs:
E NameError: name 'InputArgs' is not defined
but I removed:
if sys.version_info[1] < 9: # if less than pytorch 3.9
from typing import Sequence, Iterable
else:
There was a problem hiding this comment.
removed from __future__ import annotations from tests/gpu/torch/export/test_fsdp2_export.py
There was a problem hiding this comment.
All of this could be removed later by just using Nemo AutoModel's PP implementation
There was a problem hiding this comment.
Created an internal NVidia issue to replace validate_runtime_pipeline.py with Nemo AutoModel's PP implementation: issues/70
| # teacher_dir = ( | ||
| # '/lustre/fsw/portfolios/coreai/projects/coreai_nvfm_llm/models/' | ||
| # 'meta-llama/Meta-Llama-3.1-405B-Instruct/' | ||
| # ) |
There was a problem hiding this comment.
please remove this
Co-authored-by: Keval Morabia <28916987+kevalmorabia97@users.noreply.github.com> Signed-off-by: Daniel Korzekwa <daniel.korzekwa@gmail.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
What does this PR do?
Add sewing kit and utilities used for pruning scoring - pruning scoring is self-contained now - no dependency on internal Nvidia code.