Skip to content

Add llama converter (no dependency on internal Nvidia code) - part 1/2#545

Merged
danielkorzekwa merged 19 commits intofeature/compressfrom
dkorzekwa/llama_converter_selfcontained
Nov 13, 2025
Merged

Add llama converter (no dependency on internal Nvidia code) - part 1/2#545
danielkorzekwa merged 19 commits intofeature/compressfrom
dkorzekwa/llama_converter_selfcontained

Conversation

@danielkorzekwa
Copy link
Copy Markdown
Contributor

@danielkorzekwa danielkorzekwa commented Nov 12, 2025

What does this PR do?

Add llama converter (no dependency on internal Nvidia code) - part 1/2

  • change top-level dependencies in convert_llama3_to_decilm.py from puzzle_tools.... to modelopt.....
  • added modelopt.torch._compress.tools module
  • remove tokenization_mistral.py - not used

scope of 2/2 part (will come once part 1/2 is merged):

  • change all deeper dependencies from from puzzle_tools.... to modelopt....
  • test_convert_llama3_config_to_decilm_config.py should run without any internal nvidia dependencies

Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
…ntained

Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
@danielkorzekwa danielkorzekwa requested a review from a team as a code owner November 12, 2025 09:06
Comment on lines +30 to +37
from puzzle_tools import deci_lm_hf_code
from puzzle_tools.common import infer_weights_dtype
from puzzle_tools.deci_lm_hf_code.configuration_decilm import DeciLMConfig
from puzzle_tools.deci_lm_hf_code.modeling_decilm import DeciLMForCausalLM
from puzzle_tools.robust_json import json_dumps
from safetensors.torch import save_file as safe_save_file
from transformers.utils import SAFE_WEIGHTS_INDEX_NAME
from utils.post_init_sparse import SparsityMethod
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

decilm imports need to be fixed to modelopt path

Copy link
Copy Markdown
Contributor Author

@danielkorzekwa danielkorzekwa Nov 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is done in 2/2, see scope of 1/2 in MR description.

Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.40%. Comparing base (50a580c) to head (13ad9d6).
⚠️ Report is 1 commits behind head on feature/compress.

Additional details and impacted files
@@                Coverage Diff                @@
##           feature/compress     #545   +/-   ##
=================================================
  Coverage             73.40%   73.40%           
=================================================
  Files                   180      180           
  Lines                 18127    18127           
=================================================
  Hits                  13306    13306           
  Misses                 4821     4821           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…ntained

Signed-off-by: Daniel Korzekwa <dkorzekwa@nvidia.com>
@danielkorzekwa danielkorzekwa merged commit b121945 into feature/compress Nov 13, 2025
20 of 21 checks passed
@danielkorzekwa danielkorzekwa deleted the dkorzekwa/llama_converter_selfcontained branch November 13, 2025 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants