Some fixes and improvements to plugin output and performance #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change overall status to "warning" if an interface exceeds bandwidth limit (see NETWAYS#8 thanks to Bjoern-10101 ) - Do not show (incorrect) performance data for Interfaces which are admin down - Correct output for down interfaces if crit_on_down_flag is not true
Interface name could have incompatible characters (e.g. "/")
this way it better fits our demands but i think it's a matter of taste
and improve the output for Cisco a little bit
Write last checktime to perfdata output and try to parse it from there if no "--lastcheck" is given. --> You have to pass one argument less and this also fixes the hight traffic warnings you get if the last check(s) faild to geht new perf data but the lastcheck variable in Icinga gets updated anyway.
Print inBitps and outBitps to performance data so you can use them in graphs etc. Also fix the recognition of a recent reset which I have broken in the previous commit and fix the plugin number output.
I think it was intended this way but the code was misordered, so it did not work as expected (instead all interfaces were polled which is not really efficient especially witch many Interfaces). I also implemented a bulkget for the if-names, so we can match them with the regex too. I could only test it with a cisco switch and I do not know whether it works for Bintec.
|
I have tested (IOS / XR) this branch and sounds good to me. |
Member
|
Sorry for the (huge) delay and thank you very much for the contribution :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please see commit messages for more details.
The last two commits significantly improve the performance of the plugin, especially if you only want to monitor a few interfaces on a switch. We use the plugin for Cisco and Brocade switches and with these changes everything works as expected by now. Please note that i have not tested it with Bintec or other devices. Also I am not an experienced programmer so please have a look at the changes before merging them.
By the way thanks for the great and efficient check plugin! After making these changes we were able to significantly improve our monitoring with this plugin.