update target mean discretizer#11
Open
solegalli wants to merge 58 commits intoMorgan-Sell:target_mean_discretiserfrom
Open
update target mean discretizer#11solegalli wants to merge 58 commits intoMorgan-Sell:target_mean_discretiserfrom
solegalli wants to merge 58 commits intoMorgan-Sell:target_mean_discretiserfrom
Conversation
* initial commit. create _input_features_docstring and update datetime class * update base_encoder, base_imputer, and base_outlier * expand get_feature_names_out() code to account for 'input_features' implementation * add 'input_variables' for base_outlier, match_columns, and base_selector classes. needs accompanying code/checks * add/update 'input_features' for BaseImputer BaseSelector, and Wrappers * add _inputs_features_docstring to BaseNumericalTransformer * revise BaseNumericalTransformer * create _input_features_docstring * create check_input_features and _check_input_features_in_variables fcns * add check_input_features to base_imputer and base_encoder * add check_input_features to base_transformers * revise wrappers * revert datetime docstring to original text * fix errors * fix errors * fix errors * change _input_features_docting to _get_feature_names_out_docstring * change _input_features_docting to _get_feature_names_out_docstring * update base_encoder, base_imputer, base_outlier, and match_columns * update base_selector.py * update BaseNumericalTransformer * update parameter_checks.py * revise ValueErr text for base_selector.py * update wrappers.py * update wrappers.py * fix check_input_features * fix typecheck errors * reverted changes in parameter_checks * created global method get_feature_names_out * modified method in base transformer * remove unused import * tidy import * modify method in base encoder * modify method in base imputer * remove unused import * modify method in base outlier * modify method in match variables * modify method in base selector * modify method in wrapper * modify code style * fixes mypy error * add test get feature names out within pipeline * fix method winzoriser * fix code style * modified docstrings winsorizer method * fixes error in wrapper * modified code style base transformer * modified code style base encoder * modify docstrings get feature names out function * modify docstrings get feature names out function * reorganize code * expands tests sklearn wrapper * modify method in math features * adds test for error * fix method in relative features * expands tests * expanded test datetime * expands tests * fixes codestyle * removed indentation * updates docs2 Co-authored-by: Morgan-Sell <morganpsell@gmail.com>
* bumps version and build branch * expanded whats new * fix typo dropsi user guide * modified release data * updated contributors name * remove empty lines
…pped by SklearnTransformerWrapper (#447) * Added FunctionTransformer test and wrap refenrece * str to int in mock data
* adds error message to pass tests * fixes check_estimator tests for selectors * fixes tests selectors * fixes codestyle * removes python 3.6 from badge * specifies docs language * remove commentted block * remove support for python 3.7 * fix bug in circleci config * add support python 3.10 * update python badge in readme * remove check for variable group * modify common tests for var groups * update support for univariate and multivariate selection * remove indent * adds tests for univariate selection * remove test fail * revert psi tests to main * fix bug in common tests
* fix pandas future warning, sets as indexer no longer supported * fixes code style
* adds arcsin transformer and updates documentation * adds test for arcsin_transformer.py * test arcsin transformer * add ArcsinTranform documentation * correction of little error on doc * modifies index to add ArcsinTransformer * style correction * little modification * corrects string formatting * modifies ArcsinTransformer.rst and adds images * adds images * modifies tests on arcsin * deletes test that can be run from another file * modifies dataset for arcsin demo * adds get_feature_names_out to the demo * excludes tests on arcsin we can't run, includes sqrt in arcsin transformer * reintegrates useful tests, deletes test we can't run for the range limitation * modifies demo, adds variables * modifies range specification * modifies file with black/isort * reformats file * reformats to pass black test (still doesn't) * delete additional information part * change to pass flake8 test * adds test and modifies a little the docs * adds arcsin transformer and updates documentation * adds test for arcsin_transformer.py * test arcsin transformer * add ArcsinTranform documentation * correction of little error on doc * modifies index to add ArcsinTransformer * style correction * little modification * corrects string formatting * modifies ArcsinTransformer.rst and adds images * adds images * modifies tests on arcsin * deletes test that can be run from another file * modifies dataset for arcsin demo * adds get_feature_names_out to the demo * excludes tests on arcsin we can't run, includes sqrt in arcsin transformer * reintegrates useful tests, deletes test we can't run for the range limitation * modifies demo, adds variables * modifies range specification * modifies file with black/isort * reformats file * reformats to pass black test (still doesn't) * delete additional information part * change to pass flake8 test * adds test and modifies a little the docs * expand user guide * change wording and exp implentation in class * reorganise tests, fix bugs in tests Co-authored-by: Tommaso Pellegrino <tommasopellegrino@Air-di-Tommaso.home-life.hub> Co-authored-by: Soledad Galli <solegalli@protonmail.com>
* Correct references. Add correct reference as reference 1 and current reference is made as reference 2 * reformat correctly * add proper spacing Co-authored-by: Sangam Swadi K <sangamswadik@users.noreply.github.com>
* update files for next release * adds blog to transformation resources * add spanish blog site
* add inv_transform * corrected linting issues * add lambda invboxcox * add inverse boxcox transform * add tests for inverse transform * rename inverse transform for consistency across all transformers * remove testing statements * fix typo * Add relevant docstrings and paraphrase inverse_transform doc Co-authored-by: Sangam Swadi K <sangamswadik@users.noreply.github.com>
* fixes numpy typing error with version 1.22 and above * remove typing, use ndarray instead of array
* fixes numpy typing error with version 1.22 and above * remove typing, use ndarray instead of array
* release 1.4.1 * add enhancement
* add path to pydata theme * modify path to layout * m path * mm * bump requirement * mmm * kk * bump requirement * ,, * mm
…Encoder` (#456) * redo zero-encoding with new base transformers * linter * linter * use pandas built-in normalization * fix duplicated lines * split base categorical class according to whether it supports 'encode' errors or not * fix docs * missing comma * redo zero-encoding with new base transformers * linter * linter * use pandas built-in normalization * fix duplicated lines * split base categorical class according to whether it supports 'encode' errors or not * fix docs * missing comma * remove unnecesary docstring from common docstrings file * reverts base encoder to original representation * adds function to check parameter errors * reorganizes docstrings for param errors * reorganize init checks * reorganizes tests * add test for frequency * fix codestyle * sorts imports * formatting * formatting * reorganize imports and parameters * add Note on missing values for unseen categories * reorganize imports * remove white space Co-authored-by: Soledad Galli <solegalli@protonmail.com>
* add simple categorical levels encoder * add simple categorical levels encoder * revert base encoder to original representation * sorts imports init * reorganizes base encoder and encoders * reorganises transformer based on baseencoder * redo for new branch * rebase on branch from PR * add docs for MatchCategories * add transformer to readme * reword class function * reword user guide * replace errors by missing_values, expand tests * add transformer to general checks file, remove unused import * add example packages in docs Co-authored-by: Soledad Galli <solegalli@protonmail.com>
solegalli
force-pushed
the
MeanDiscretiser
branch
from
72b8ee6 to
6cdbc27
Compare
Owner
|
Hi @solegalli, I'm confused I thought we weren't moving forward with this transformer. Why the change of heart? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Morgan-Sell
I did some work on the MeanDiscretiser:
Also, rebased main to get the latest changes, that is why you see all the below irrelevant commits. If you sync your repo you probably will be able to see my changes.
There are 2 small bits that remain doing and then we are good to merge:
Would you be able to do that when you are back from hols?