[GTFS Fares v2] Update forbidden for network_id in routes.txt if networks.txt exists too#75
Closed
[GTFS Fares v2] Update forbidden for network_id in routes.txt if networks.txt exists too#75
Conversation
|
|
adde50f to
770fbcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This is just a simple adjustment to make sure the reference is consistent. In google#405 where
networks.txtandroute_networks.txtwere proposed, the community decided to keep a separation betweennetwork_idinroutes.txton one side andnetworks.txt+route_networks.txton the other side (to maintain backward compatibility since the features were introduced at different times).Describe the Problem
The spec mention clearly in the dataset section that
networks.txtandroute_networks.txtare forbidden ifnetwork_idexists in routes.txt. However, fornetwork_idinroutes.txtitself, it only says that the field is forbidden ifroute_networks.txtexists (ONLY, and notnetworks.txtas well).Use Cases
Proposed Solution
Add
networks.txtto files that forbid the existence ofnetwork_idinroutes.txtThis is a documentation change, since the change is just to maintain consistency in the reference file.
Type of change
GTFS Schedule
GTFS Realtime
Proposed Discussion Period
In compliance with the governance, I propose a 7-day discussion period followed by 7 days for reviewing. If there's no issue, this PR can be merged directly.
Proposal Update Tracker
Checklist