Conversation
Added Washington DC Metrorail example
Added MTA Metro-North example illustrating the combined use of time variable fares and zone based fares.
isabelle-dr
left a comment
isabelle-dr
left a comment
There was a problem hiding this comment.
Thank you for working on this @Sergiodero!
This is a great addition to the examples page and it makes it very clear how to use timeframes.
I've added a few suggestions intended to slightly increase the clarity. Feel free to only take what you think is an improvement.
Another thing I wonder if we should make an explicit mention is that timeframes are using local time semantics, with a link to this section of the spec, because this is a new concept introduced.
Resolves comments from first round of reviews on time-variable fares examples.
|
Thanks for the review @isabelle-dr! All comments have been addressed in the latest commit. I'll work on a new commit now to update the NYC example so that it matches the new screenshots to illustrate the example. |
Replaced time-variable fares + zone based fares example with trip to Cold Spring, NY. Added Apple Maps screenshots.
|
Last updates now reflect changes made to the time-variable + zonal fares example and include screen captures from Apple Maps. |
isabelle-dr
left a comment
isabelle-dr
left a comment
There was a problem hiding this comment.
Thank you for updating this, LGTM!
3 participants
A vote to add time-variable fares has passed. These changes add two different use cases on the Fares v2 example page to illustrate the use of time-variable fares on its own (Washington DC example), and in combination with zone-based fares (MTA Metro-North example).