build(deps): bump react-router-dom from 7.13.0 to 7.13.1 in /apps/lexfiat#410
Merged
MightyPrytanis merged 1 commit intomainfrom Mar 10, 2026
Conversation
dependabot
bot
added
dependencies
dependabot
bot
added
dependencies
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/apps/lexfiat/react-router-dom-7.13.1
branch
from
693d6e3 to
e4606bc
Compare
Bumps [react-router-dom](https://github.com/remix-run/react-router/tree/HEAD/packages/react-router-dom) from 7.13.0 to 7.13.1. - [Release notes](https://github.com/remix-run/react-router/releases) - [Changelog](https://github.com/remix-run/react-router/blob/main/packages/react-router-dom/CHANGELOG.md) - [Commits](https://github.com/remix-run/react-router/commits/react-router-dom@7.13.1/packages/react-router-dom) --- updated-dependencies: - dependency-name: react-router-dom dependency-version: 7.13.1 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
force-pushed
the
dependabot/npm_and_yarn/apps/lexfiat/react-router-dom-7.13.1
branch
from
e4606bc to
e0e1318
Compare
MightyPrytanis
deleted the
dependabot/npm_and_yarn/apps/lexfiat/react-router-dom-7.13.1
branch
MightyPrytanis
added a commit
that referenced
this pull request
Mar 11, 2026
… and correct assertions (#496) The onboarding integration tests were broken in multiple compounding ways: missing imports (`startAppServer`, `generateAccessToken`) caused `beforeAll` to fail silently, leaving `authHeaders` empty so every authenticated route returned 401; `const testPort`/`const baseUrl` were reassigned inside the `listen` callback (runtime `TypeError`); and a duplicate server startup raced with itself on port 5003. ## Changes **Server startup (`beforeAll`)** - Replaced broken inline `http.createServer` + `listen` block (plus a second redundant `startAppServer` call) with a single `startAppServer(app, process.env.TEST_PORT)` — uses `TEST_PORT` env var if set, otherwise OS-assigned ephemeral port (0), eliminating `EADDRINUSE` in CI - Wraps startup in `try/catch` with actionable error messages distinguishing fixed-port conflicts from ephemeral allocation failures - Logs which port is being used before startup so CI output is traceable ```typescript const preferredPort = process.env.TEST_PORT; console.log(`[Onboarding Tests] Starting test server on ${preferredPort ? `port ${preferredPort}` : 'ephemeral port (0)'}...`); try { const started = await startAppServer(app, preferredPort); baseUrl = started.baseUrl; stopServer = started.stop; } catch (err: any) { const portHint = preferredPort ? `Port ${preferredPort} may already be in use. Set TEST_PORT to a different available port, or unset it to use an ephemeral port.` : 'Ephemeral port allocation failed — check system resource limits.'; console.error(`[Onboarding Tests] ❌ Server startup failed: ${err.message}. ${portHint}`); throw err; } ``` **Imports & structure** - Added missing `startAppServer` (from `test-utils/test-server.ts`) and `generateAccessToken` (from `middleware/security.ts`) - Removed unused outer `describe` wrapper, unused `vi`/`Server`/`AddressInfo` imports - Removed `beforeEach` that called non-existent `profileStore.clear()` - `afterAll` now calls `stop()` returned by `startAppServer` **Test assertions** Fixed three assertions that matched a stale route shape (route wraps responses as `{ success, profile }` / `{ success, baseline }`): - `data.primaryJurisdiction` → `data.profile?.primaryJurisdiction` (×2) - `data.minimumHoursPerWeek` → `data.baseline?.minimumHoursPerWeek` <!-- START COPILOT ORIGINAL PROMPT --> <details> <summary>Original prompt</summary> > The onboarding API integration tests in Cyrano/tests/routes/onboarding.test.ts currently default to port 5003, which can lead to 'ECONNREFUSED' errors or port-in-use conflicts in CI and local runs. To resolve this: > > - Refactor test startup to allow easy selection of the listening port via an environment variable (TEST_PORT), falling back to 0 (random port) if none is set or if 5003 is unavailable. > - Update fetch calls in the test suite to always use the actual resolved port the test server listens on. > - Improve error reporting in the beforeAll() server start block. Clearly output if port is unavailable and suggest user action if a port conflict or startup error occurs (e.g., instruct to set TEST_PORT or kill existing process). > - Add console output to CI logs indicating which port is being used for onboarding tests, and highlight any startup problems clearly. > > Verify this resolves the connection errors and failed assertions reported in CI (see job 66213858412 and PR #410). > > The following is the prior conversation context from the user's chat exploration (may be truncated): > > User: Please find a solution for failing job 66213858412. Use the logs, job definition, and any referenced files where the failure occurred. Keep your response focused on the solution and include code suggestions when appropriate. > > Assistant: The job failed because the tests could not connect to the server at localhost:5003 (Error: connect ECONNREFUSED ::1:5003 and 127.0.0.1:5003). This prevented the onboarding API integration tests from running, resulting in many expected true-to-be-false assertion errors and a test pass rate below the 85% threshold. > > Solution: > > 1. Ensure the test server starts on port 5003 before tests attempt to connect. In Cyrano/tests/routes/onboarding.test.ts, the test server is created in a beforeAll hook, but if the port is already in use or if the server fails to initialize, subsequent tests will fail with connection refused. > 2. Check for code or environment issues that could block port 5003. Confirm nothing else is using the port, or modify the test to select an available port (e.g., by passing 0 to server.listen for a random free port). > 3. Improve server startup by capturing and reporting startup errors more clearly. > 4. Validate that fetch requests in your onboarding tests use the actual port where the server is listening. > > Example fix for port conflict handling (in onboarding.test.ts): > > ```typescript > const http = await import('http'); > let resolvedPort = testPort; > server = http.createServer(app); > server.listen(testPort, () => { > resolvedPort = server.address().port; // use the actual port assigned (if 0) > // proceed with tests using resolvedPort > }); > server.on('error', err => { > if (err.code === 'EADDRINUSE') { > console.error(`Port ${testPort} in use, try setting TEST_PORT to a free port`); > } > throw err; > }); > ``` > > You can also set TEST_PORT to a unique value for parallel CI runs or ensure the port is always free before tests start. > > After addressing the server startup and port issue, rerun the tests to confirm the pass rate exceeds 85% and all onboarding API routes are reachable. > > User: I could swear we just fixed these errors. Oh well. Open PR to fix > > Assistant: Please confirm: should the PR be opened in MightyPrytanis/codebase with a focus on ensuring the test server reliability in Cyrano/tests/routes/onboarding.test.ts (specifically, handling port 5003 issues and improving robustness of server startup and teardown)? > > If so, would you prefer I: > - Automatically use a random available port if 5003 is in use? > - Make TEST_PORT selectable via environment, and improve error reporting? > - Or do you have specific requirements for how to address this? > > Let me know your preference so I can open the pull request accordingly. > > User: make selectable and improve error reporting > > Assistant: I've started a pull request for MightyPrytanis/codebase to make the onboarding test port selectable via TEST_PORT, improve error reporting, and ensure the resolved port is correctly used throughout the test suite. This will address the connection issues you've seen. > > </details> <!-- START COPILOT CODING AGENT SUFFIX --> *This pull request was created from Copilot chat.* > <!-- START COPILOT CODING AGENT TIPS --> --- 🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. [Learn more about Advanced Security.](https://gh.io/cca-advanced-security)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps react-router-dom from 7.13.0 to 7.13.1.
Changelog
Sourced from react-router-dom's changelog.
Commits
aa3f078chore: Update version for release (#14829)3207a5cchore: Update version for release (pre) (#14814)Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)