Skip to content

Cleanup of some obsolete configuration code#392

Merged
MichaConrad merged 7 commits intodevfrom
fix-386
Oct 11, 2025
Merged

Cleanup of some obsolete configuration code#392
MichaConrad merged 7 commits intodevfrom
fix-386

Conversation

@MichaConrad
Copy link
Collaborator

  • Cleanup of some obsolete configuration code, fixes 386
  • Adding User as a config option for a Redis connection, that is supported in Redis since version 7.0

@MichaConrad MichaConrad requested a review from Copilot October 11, 2025 11:48
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request removes obsolete logger factory configuration code and adds support for Redis User authentication for Redis 6+ ACL features.

  • Removed deprecated logger factory configuration schemas and related code
  • Added User property to Redis configuration for ACL authentication support
  • Improved error handling in Redis connection management with try-catch around connection disposal

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tools/cacheManager.json Removed obsolete logger factory schema definitions and fixed serializer description
src/CacheManager.StackExchange.Redis/RedisConnectionManager.cs Added try-catch around connection disposal for better error handling
src/CacheManager.StackExchange.Redis/RedisConfigurationBuilder.cs Added WithUser method to support Redis ACL authentication
src/CacheManager.StackExchange.Redis/RedisConfiguration.cs Added User property and parameter to constructor for Redis ACL support
src/CacheManager.Microsoft.Extensions.Configuration/MicrosoftConfigurationExtensions.cs Replaced logger factory type with NotSupportedException and helpful migration message
src/CacheManager.Core/CacheManager.Core.csproj Updated to use latest C# language version
samples/CacheManager.Examples/cache.json Added new sample configuration file
samples/CacheManager.Examples/Program.cs Enhanced examples with additional cache manager demonstrations
samples/CacheManager.Examples/CacheManager.Examples.csproj Added cache.json as content file to be copied to output
Documentation/apispec/CacheManager_Core_MicrosoftLoggingBuilderExtensions.md Removed obsolete documentation file
CacheManager.sln Removed reference to deleted documentation file

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Michael Conrad and others added 4 commits October 11, 2025 13:54
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@MichaConrad MichaConrad merged commit debe173 into dev Oct 11, 2025
2 checks passed
@MichaConrad MichaConrad deleted the fix-386 branch November 6, 2025 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants