Cleanup of some obsolete configuration code#392
Merged
MichaConrad merged 7 commits intodevfrom Oct 11, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request removes obsolete logger factory configuration code and adds support for Redis User authentication for Redis 6+ ACL features.
- Removed deprecated logger factory configuration schemas and related code
- Added User property to Redis configuration for ACL authentication support
- Improved error handling in Redis connection management with try-catch around connection disposal
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/cacheManager.json | Removed obsolete logger factory schema definitions and fixed serializer description |
| src/CacheManager.StackExchange.Redis/RedisConnectionManager.cs | Added try-catch around connection disposal for better error handling |
| src/CacheManager.StackExchange.Redis/RedisConfigurationBuilder.cs | Added WithUser method to support Redis ACL authentication |
| src/CacheManager.StackExchange.Redis/RedisConfiguration.cs | Added User property and parameter to constructor for Redis ACL support |
| src/CacheManager.Microsoft.Extensions.Configuration/MicrosoftConfigurationExtensions.cs | Replaced logger factory type with NotSupportedException and helpful migration message |
| src/CacheManager.Core/CacheManager.Core.csproj | Updated to use latest C# language version |
| samples/CacheManager.Examples/cache.json | Added new sample configuration file |
| samples/CacheManager.Examples/Program.cs | Enhanced examples with additional cache manager demonstrations |
| samples/CacheManager.Examples/CacheManager.Examples.csproj | Added cache.json as content file to be copied to output |
| Documentation/apispec/CacheManager_Core_MicrosoftLoggingBuilderExtensions.md | Removed obsolete documentation file |
| CacheManager.sln | Removed reference to deleted documentation file |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/CacheManager.Microsoft.Extensions.Configuration/MicrosoftConfigurationExtensions.cs
Outdated
Show resolved
Hide resolved
src/CacheManager.StackExchange.Redis/RedisConfigurationBuilder.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This was referenced Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Useras a config option for a Redis connection, that is supported in Redis since version 7.0