refactor!: Standardise SnapInterfaceController action names and types#3912
Merged
Mrtenz merged 4 commits intocontroller-refactorsfrom Mar 23, 2026
Merged
Conversation
| @@ -1 +1,21 @@ | |||
| export * from './SnapInterfaceController'; | |||
| export type { | |||
| ExpandedView, | |||
Member
There was a problem hiding this comment.
Is ExpandedView used anywhere else?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## controller-refactors #3912 +/- ##
=======================================================
Coverage ? 98.55%
=======================================================
Files ? 425
Lines ? 12343
Branches ? 1935
=======================================================
Hits ? 12165
Misses ? 178
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| SnapInterfaceControllerGetStateAction, | ||
| SnapInterfaceControllerState, | ||
| SnapInterfaceControllerStateChangeEvent, | ||
| StoredInterface, |
Member
There was a problem hiding this comment.
Is StoredInterface used?
Member
Author
There was a problem hiding this comment.
Yes, mainly in tests though.
FrederikBolding
approved these changes
Mar 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This renames all
SnapInterfaceControlleraction and event names and types to follow theController...Actionpattern used in most other controllers.Note
Medium Risk
Breaking API/type rename for
SnapInterfaceControlleraction types and exports, plus a new handler-registration mechanism; risk is mainly integration/compile-time breakage and potential mismatches in messenger wiring if any method list is incomplete.Overview
Standardizes
SnapInterfaceControlleraction typing to theControllerNameDoSomethingActionpattern (breaking). A new auto-generatedSnapInterfaceController-method-action-types.tsdefines method action types (andSnapInterfaceControllerMethodActions), replacing the previously inlineCreateInterface/GetInterface/etc. type aliases.SnapInterfaceControllernow registers actions viamessenger.registerMethodActionHandlerswith an explicit exposed-method list, andinterface/index.tsupdates exports to surface the new action types while narrowing what’s re-exported from the controller module. Downstream usages (e.g.,SnapController,SnapInsightsController,snaps-simulation) are updated to reference the renamedSnapInterfaceController...Actiontypes, and the changelog documents the breaking rename set.Written by Cursor Bugbot for commit 4cd791b. This will update automatically on new commits. Configure here.